Skip to content

🔒 Fix potential XSS vulnerability in JSON-LD script tags#11

Open
marcin2121 wants to merge 1 commit intomainfrom
fix-xss-json-ld-341306171059743030
Open

🔒 Fix potential XSS vulnerability in JSON-LD script tags#11
marcin2121 wants to merge 1 commit intomainfrom
fix-xss-json-ld-341306171059743030

Conversation

@marcin2121
Copy link
Copy Markdown
Owner

🎯 What: The vulnerability fixed
In app/layout.tsx, the JSON-LD schema was being injected into a <script> tag using dangerouslySetInnerHTML directly with JSON.stringify(schema).

⚠️ Risk: The potential impact if left unfixed
While the current schema appears to be static or trusted, if any user input were ever to be included in the schema in the future, an attacker could potentially inject a payload like </script><script>alert(1)</script> into a schema field. JSON.stringify does not escape HTML characters, so this payload would break out of the initial <script> tag and execute arbitrary JavaScript, leading to Cross-Site Scripting (XSS).

🛡️ Solution: How the fix addresses the vulnerability
The output of JSON.stringify(schema) is now chained with .replace(/</g, '\\u003c'). This replaces all occurrences of < with its unicode representation \u003c, which is perfectly valid JSON and correctly interpreted by the browser, but prevents the string from being interpreted as an HTML tag like </script>.


PR created automatically by Jules for task 341306171059743030 started by @marcin2121

Sanitized JSON stringification in layout.tsx by escaping `<` characters to prevent escaping out of the script context.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant