Update peer dependencies to support React 17 and React-Dom 17 #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
Thanks for this project! We use it heavily in a number of our projects. With the recent release of NPM 7 we have gone through the process of updating a number of our dependencies. NPM 7 automatically installs peer dependencies which causes issues with projects that want to use React 17. This shouldn't be a breaking change and React 17 in itself is relatively lightweight and does not contain any new developer features. Let me know if this makes sense!
Testing
Tested locally
Notes:
I also considered using
^16.8.4 || ^17.0.0to be more strict but leaned towards>=for flexibility.