Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose raw license details #27

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jbergknoff-rival
Copy link

This is a great tool, thank you!

I'm writing a wrapper around node-licensecheck to add some business rules (whitelisting). Unfortunately, the raw details of the licenses aren't exposed, only the stringified form, which is pretty difficult to cleanly parse in its most general form (multiple licenses, multiple URLs).

It seems reasonable to expose those so that the code can be reused without trying to parse the stringified versions of the licenses.

@jbergknoff-rival
Copy link
Author

The failing test also fails on the master branch. I think test/self-dev.json may need to be updated. I'm kind of confused how the test passed on master two years ago. For instance, self-dev.json doesn't have eslint listed as a top level dependency. It has a bunch of dependencies under spdx-license-list [1] though that package actually has none.

[1]

"name": "spdx-license-list",
"license": "MIT License (http://www.opensource.org/licenses/MIT)",
"deps": [

@marcello3d
Copy link
Owner

The project and tests are pretty old so that's not too surprising… it's likely due to the fact that there's no yarn/npm lock file to pin the sub-dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants