Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: BottomTab component #747

Merged
merged 9 commits into from
Jun 29, 2024
Merged

feat: BottomTab component #747

merged 9 commits into from
Jun 29, 2024

Conversation

marc2332
Copy link
Owner

Depends on #745

@marc2332 marc2332 added the enhancement 🔥 New feature or request label Jun 29, 2024
Copy link

codecov bot commented Jun 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 47 lines in your changes missing coverage. Please review.

Project coverage is 73.58%. Comparing base (67d3144) to head (d3390b3).
Report is 2 commits behind head on main.

Current head d3390b3 differs from pull request most recent head 53cbac7

Please upload reports for the commit 53cbac7 to get more accurate results.

Files Patch % Lines
crates/components/src/animated_router.rs 0.00% 33 Missing ⚠️
crates/components/src/tabs.rs 0.00% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #747      +/-   ##
==========================================
- Coverage   73.75%   73.58%   -0.17%     
==========================================
  Files         198      199       +1     
  Lines       20352    20399      +47     
==========================================
  Hits        15011    15011              
- Misses       5341     5388      +47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from feat/animated-router-transitions to main June 29, 2024 14:36
@marc2332 marc2332 marked this pull request as ready for review June 29, 2024 14:39
@marc2332 marc2332 merged commit ab8c3f3 into main Jun 29, 2024
6 checks passed
@marc2332 marc2332 deleted the feat/bottom-tabsbar branch June 29, 2024 14:41
This was referenced Jun 29, 2024
This was referenced Jul 9, 2024
@github-actions github-actions bot mentioned this pull request Aug 3, 2024
@github-actions github-actions bot mentioned this pull request Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🔥 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant