Skip to content

use toolchain files as single source of truth#1791

Open
sectore wants to merge 4 commits intomarc2332:mainfrom
sectore:toolchain
Open

use toolchain files as single source of truth#1791
sectore wants to merge 4 commits intomarc2332:mainfrom
sectore:toolchain

Conversation

@sectore
Copy link
Copy Markdown

@sectore sectore commented Apr 14, 2026

for Rust versions (default + nightly).

Problem

Currently Rust versions (default + nightly) are defined all over the place. Check PR #1638 and you will know.

Fix

Use two toolchain files for default and nightly as a single source of truth

Changes

  • Add another rust-toolchain-nightly.toml (besides default rust-toolchain.toml)
  • Extend justfile to get Rust versions from toolchain files.
  • In .github/workflows/*.yml files use actions-rust-lang/setup-rust-toolchain to handle different toolchain files (instead of hard-coded Rust versions)
  • Ignore .direnv folder created by direnv / Nix users
  • flake.nix: Add missing dependencies, fix deprecated xorg packages
  • Run nix flake update to get latest inputs, especially latest Rust versions.

TODO

  • Check if CI/GH workflows still work DONE

for Rust versions (default + nightly).
@sectore sectore requested a review from marc2332 as a code owner April 14, 2026 09:48
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.30%. Comparing base (e735044) to head (dc727ad).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1791   +/-   ##
=======================================
  Coverage   61.30%   61.30%           
=======================================
  Files         310      310           
  Lines       39433    39433           
=======================================
  Hits        24174    24174           
  Misses      15259    15259           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Owner

@marc2332 marc2332 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you make this specific change? Like, how did you end up finding this "issue", solving it and opening a PR? Because, if I have to be honest, this looks AI generated. I am in favor of AI, but against slop.

@sectore
Copy link
Copy Markdown
Author

sectore commented Apr 14, 2026

As a Nix user I have to figure out how to run this project, especially by having different toolchain. This PR includes all changes I needed. It's not AI generated (no vibe-coding), but I have paired w/ Claude.

If you think it's slop to be more DRY, just ignore/close it. Changes are based on few hours work btw, AI would not do that in this way. Instead AI is still happy to put same versions/hashes everywhere and at different places (which is more than questionable). Call it human experiences vs. AI. Hope this PR makes more sense now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants