use toolchain files as single source of truth#1791
use toolchain files as single source of truth#1791sectore wants to merge 4 commits intomarc2332:mainfrom
toolchain files as single source of truth#1791Conversation
for Rust versions (default + nightly).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1791 +/- ##
=======================================
Coverage 61.30% 61.30%
=======================================
Files 310 310
Lines 39433 39433
=======================================
Hits 24174 24174
Misses 15259 15259 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
to avoid overriding `RUSTUP_TOOLCHAIN`
marc2332
left a comment
There was a problem hiding this comment.
Why did you make this specific change? Like, how did you end up finding this "issue", solving it and opening a PR? Because, if I have to be honest, this looks AI generated. I am in favor of AI, but against slop.
|
As a Nix user I have to figure out how to run this project, especially by having different toolchain. This PR includes all changes I needed. It's not AI generated (no vibe-coding), but I have paired w/ Claude. If you think it's slop to be more DRY, just ignore/close it. Changes are based on few hours work btw, AI would not do that in this way. Instead AI is still happy to put same versions/hashes everywhere and at different places (which is more than questionable). Call it human experiences vs. AI. Hope this PR makes more sense now. |
for Rust versions (default + nightly).
Problem
Currently Rust versions (default + nightly) are defined all over the place. Check PR #1638 and you will know.
Fix
Use two
toolchainfiles fordefaultandnightlyas a single source of truthChanges
rust-toolchain-nightly.toml(besides defaultrust-toolchain.toml)justfileto get Rust versions fromtoolchainfiles..github/workflows/*.ymlfiles useactions-rust-lang/setup-rust-toolchainto handle differenttoolchainfiles (instead of hard-coded Rust versions).direnvfolder created bydirenv/ Nix usersxorgpackagesnix flake updateto get latest inputs, especially latest Rust versions.TODO
Check if CI/GH workflows still workDONE