mv Enum::getBy[Name|Ordinal]() to Enum::by[Name|Ordinal]() & add Enum::byValue() #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just for consistency to differ the methods of getting something out of an enumeration/set/enumerator using
get*()with the methods for accessing an enumerator (Enum::by*()).The method
Enum::get($valueOrInstance)still exists but I added the methodEnum::byValue($value)which doesn't allow an already instantiated enumerator as argument.-> So for consistency the method
Enum::get($valueOrInstance)doesn't really follow this naming but calling it something likebyValueOrInstancesounds stange to me and also this is a widely used method that I wouldn't like to rename.@prolic Do you think this makes sense even with the given BC later on removing deprecated methods?