Skip to content

fix error on clone $enum #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2022
Merged

fix error on clone $enum #155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Enum.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ public function __toString(): string
* @throws LogicException Enums are not cloneable
* because instances are implemented as singletons
*/
final protected function __clone()
final public function __clone()
{
throw new LogicException('Enums are not cloneable');
}
Expand Down
4 changes: 1 addition & 3 deletions tests/MabeEnumTest/EnumTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,12 +355,10 @@ public function testCloneNotCallableAndThrowsLogicException(): void

$reflectionClass = new ReflectionClass($enum);
$reflectionMethod = $reflectionClass->getMethod('__clone');
$this->assertTrue($reflectionMethod->isProtected(), 'The method __clone must be protected');
$this->assertTrue($reflectionMethod->isFinal(), 'The method __clone must be final');

$reflectionMethod->setAccessible(true);
$this->expectException(LogicException::class);
$reflectionMethod->invoke($enum);
clone $enum;
}

public function testNotSerializable(): void
Expand Down