fix error

maranran · May 16, 2018 · d31c71a · d31c71a
1 parent ca0da6a
commit d31c71a
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 13 deletions.
diff --git a/lib/rules/aria-props.js b/lib/rules/aria-props.js
@@ -21,19 +21,21 @@ module.exports = {
     return VueUtils.defineTemplateBodyVisitor(context, {
       "VAttribute" (node) {
         const name = (!node.directive && node.key.name)
-          || (node.key.name === 'bind' && node.key.argument);
-        const normalizedName = name.toLowerCase();
-        if (normalizedName.indexOf('aria-') !== 0) {
-          return;
+          || (node.directive && node.key.name === 'bind' && node.key.argument);
+        if (name) {
+          const normalizedName = name.toLowerCase();
+          if (normalizedName.indexOf('aria-') !== 0) {
+            return;
+          }
+          const isValid = [...aria.keys()].indexOf(normalizedName) > -1;
+          if (isValid) {
+            return
+          }
+          context.report({
+            node,
+            message: `${name}: This attribute is an invalid ARIA attribute.`
+          });
         }
-        const isValid = [...aria.keys()].indexOf(normalizedName) > -1;
-        if (isValid) {
-          return
-        }
-        context.report({
-          node,
-          message: `${name}: This attribute is an invalid ARIA attribute.`
-        });
       }
     }, altRule.create(context))
   }

diff --git a/tests/lib/rules/aria-role.js b/tests/lib/rules/aria-role.js
@@ -33,7 +33,10 @@ tester.run('aria-role', rule, {
     },
     {
       filename: 'test.vue',
-      code: '<template><Foo :role="role"></Foo></template>',
+      code: '<template><Foo role="maran"></Foo></template>',
+      options: [{
+        ignoreNonDOM: true
+      }]
     },
     {
       code: `