RD-578_space-box #162
Open
RD-578_space-box #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- transparent test images - allow config for object, `path` string or `preset` string
- refactor gradient shader to allow for proper scaling - refactor classes to separate halo and spacebox concerns as they may be used separately. - restructure directory appropriately given they're separate now - utility function to convert css color string to [r,g,b,a] vec4
added 4 commits
March 6, 2025 15:40
sasaprodribaba
approved these changes
Mar 7, 2025
added 8 commits
March 10, 2025 15:36
…ialGradientLayer and Spacebox
…for parsing color.
added 8 commits
March 24, 2025 10:09
…in map initializer
DominikCoal
approved these changes
Mar 31, 2025
- handle undefined `style` returned from `Map.getStyle()` and warn user - Log context in warnings in RadialGradientLayer and CubemapLayer
-add step to check if build failed silently. - update husky precommit to run typescheck - add typechecking to github action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
https://maptiler.atlassian.net/wiki/spaces/CD/pages/2848555013/Space+-+globe+background+stars+halo
Description
Acceptance
Checklist