RD-1737 Add session param to MapTiler controller#109
Open
katemihalikova wants to merge 1 commit intonextfrom
Open
RD-1737 Add session param to MapTiler controller#109katemihalikova wants to merge 1 commit intonextfrom
katemihalikova wants to merge 1 commit intonextfrom
Conversation
lesbaa
reviewed
Feb 20, 2026
| } | ||
|
|
||
| /** @internal Not to be called directly */ | ||
| override onAdd(map: SDKMap): HTMLElement { |
Contributor
There was a problem hiding this comment.
would protected work here or does this need to be public because it's called by the SDK?
lesbaa
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Allow users of MapTiler SDK use session-based billing.
Description
Added
sessionoption that does the same as its namesake in MapTiler SDK. The options is not available in other library controller classes nor in geocoder webcomponent.Also moved the existing MapTiler SDK specific code into the MapTiler SDK controller class as to keep it all in the right place.
Acceptance
Manual testing, linting.