Skip to content

fix onTileError #2196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 23, 2024
Merged

fix onTileError #2196

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d93439
fix onTileError
fuzhenn Jan 23, 2024
b325ea6
fix lint and add some comment
fuzhenn Jan 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/renderer/layer/tilelayer/TileLayerCanvasRenderer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,6 @@ class TileWorkerConnection extends Actor {
}
}

const BLANK_IMAGE = new Image();

/**
* @classdesc
* Renderer class based on HTML5 Canvas2D for TileLayers
Expand Down Expand Up @@ -759,7 +757,10 @@ class TileLayerCanvasRenderer extends CanvasRenderer {
}

resetTileLoadTime(tileImage) {
tileImage.loadTime = now();
// loadTime = 0 means a tile from onTileError
if (tileImage.loadTime !== 0) {
tileImage.loadTime = now();
}
}

onTileError(tileImage, tileInfo) {
Expand All @@ -785,7 +786,6 @@ class TileLayerCanvasRenderer extends CanvasRenderer {
tileImage.src = errorUrl;
}
}
tileImage = tileImage instanceof Image ? tileImage : BLANK_IMAGE;
this.abortTileLoading(tileImage, tileInfo);

tileImage.loadTime = 0;
Expand Down