Skip to content

Refactor python workers #789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ElJocho
Copy link
Collaborator

@ElJocho ElJocho commented May 22, 2023

No description provided.

ElJocho and others added 3 commits May 16, 2023 16:25
@ElJocho ElJocho changed the base branch from master to refactor-python-workers May 22, 2023 09:42
Comment on lines +95 to +97
self.language = "en-us" if "language" not in project_draft.keys() else project_draft["language"]
self.appId = None if "appId" not in project_draft.keys() else project_draft["appId"]
self.manualUrl = None if "manualUrl" not in project_draft.keys() else project_draft["manualUrl"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
self.language = "en-us" if "language" not in project_draft.keys() else project_draft["language"]
self.appId = None if "appId" not in project_draft.keys() else project_draft["appId"]
self.manualUrl = None if "manualUrl" not in project_draft.keys() else project_draft["manualUrl"]
self.language = project_draft.get("language", "en-us")
self.appId = project_draft.get("appId", None)
self.manualUrl = project_draft.get("manualUrl", None)

@Hagellach37 Hagellach37 merged commit 14cf2fb into mapswipe:refactor-python-workers May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants