fix groups height issue #1 #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericboucher
approved these changes
Feb 15, 2018
| @@ -254,25 +262,31 @@ def get_vertical_slice(geomcol, zoom): | |||
| pixel = lat_long_zoom_to_pixel_coords(ymax, xmin, zoom) | |||
| tile = pixel_coords_to_tile_address(pixel.x, pixel.y) | |||
| TileX_left = tile.x | |||
| TileY_top = tile.y | |||
|
|
|||
| # this is a fix for incorrect groups height | |||
There was a problem hiding this comment.
Can you be a bit more precise around what the fix is? What is happening?
ericboucher
added a commit
that referenced
this pull request
May 18, 2018
# This is the 1st commit message: Add Travis.ci and docker # The commit message #2 will be skipped: # Add gdal # The commit message #3 will be skipped: # Move sudo # The commit message #4 will be skipped: # No venv # The commit message #5 will be skipped: # Re-add sudo # The commit message #6 will be skipped: # libgdal dev # The commit message #7 will be skipped: # Add python3 dev # The commit message #8 will be skipped: # Add gdal-bin # The commit message #9 will be skipped: # Add Python devel # The commit message #10 will be skipped: # Update # The commit message #1 will be skipped: # Add libgcc # The commit message #2 will be skipped: # Try force imports # The commit message #3 will be skipped: # Add test # The commit message #4 will be skipped: # Test other naming # The commit message #5 will be skipped: # Add export # The commit message #6 will be skipped: # Move export # The commit message #7 will be skipped: # Add setup # The commit message #8 will be skipped: # Add init files
maze2point0
pushed a commit
that referenced
this pull request
Dec 14, 2018
fix groups height issue #1
Hagellach37
pushed a commit
that referenced
this pull request
May 22, 2023
add test for group and task creation for tile classification project …
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The grouping algorithm was adjusted.
We avoid calculating the Tile coordinates from the geometries all the time, and just do it initially. Afterwards, tile coordinates are derived from the coordinates of the previous group.