Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add idea 2024.1 to build matrix #189

Merged
merged 3 commits into from
Apr 21, 2024

Conversation

hduelme
Copy link
Contributor

@hduelme hduelme commented Apr 9, 2024

Added latest released version to build matrix

@hduelme hduelme force-pushed the add-2024.1-to-build-matrix branch from e66d99c to a233bea Compare April 9, 2024 21:29
@hduelme
Copy link
Contributor Author

hduelme commented Apr 9, 2024

I also update codecov/codecov-action to v3. The old version failed to upload.

@thunderhook
Copy link
Contributor

@hduelme Thanks.

Interestingly now v3 seems to fail when uploading it. Any idea why that happens?

@hduelme
Copy link
Contributor Author

hduelme commented Apr 21, 2024

@thunderhook yes it's a known issue of codecov see codecov/codecov-action#598

Seems like they published a v4 to address this issue.

@hduelme
Copy link
Contributor Author

hduelme commented Apr 21, 2024

One thing to not is that tokenless uploading is no longer supported in v4. If the project currently doesn't have a token see https://docs.codecov.com/docs/adding-the-codecov-token#github-actions

@thunderhook
Copy link
Contributor

Thanks @hduelme

I will merge this for now. @filiphr have a look at what @hduelme wrote about the codecov token.
I don't know if you have anything to do with it.

@thunderhook thunderhook merged commit 5b12802 into mapstruct:main Apr 21, 2024
9 checks passed
@thunderhook
Copy link
Contributor

OK, next time I'll leave the merge to you @filiphr 😅

Pipeline looked good (see details above) and everything went fine:

The main branch can't upload the coverage report now due to the missing token:

So we'll have to add a token now.

@filiphr
Copy link
Member

filiphr commented Apr 27, 2024

@thunderhook I've added the token in 4fa44fb. However, it seems like the coverage is now 0 (https://app.codecov.io/github/mapstruct/mapstruct-idea). Perhaps something is not correct with what Jacoco generates

@filiphr filiphr added this to the 1.7.0 milestone Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants