-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for MapStruct SPI #91
Comments
Having same issue when trying to use the protobuf SPI |
@coney This ia a tricky one to be honest. There is no way for us to invoke the SPI from within the plugin. What we could offer perhaps is a way for people to somehow configure how certain methods need to be ignored. @91wzhang supporting the protobuf SPI is perhaps that we need to look into independently. I would suggest creating a separate issue for that |
Great, maybe a simple configurable regex pattern is enough for my scenario |
That is an interesting idea @coney. We can look into that one. |
@coney would you be interested in providing this functionality to the plugin? |
Thanks @jomu78. I've added a response on the PR in #150 (comment) |
We are considering to use https://github.com/entur/mapstruct-spi-protobuf like @91wzhang and would require a solution for this issue #106 the mapstruct protobuf processor works fine in maven builds, but emits errors in intellij is anyone working on a solution? |
@kruijs-bbraun I don't think that anyone is working on a solution for this. My old comment (#91 (comment)) still stands. |
okay, thanks for the heads up. I think it might as well have been an avoidable misconfiguration on my side. |
My DTOs are auto generated. each field is generated with an setter(setXXX) and chained accessor(withXXX). I wrote a customized
AccessorNamingStrategy
SPI to exclude those methods start withwith
and added the SPI to my project's preprocessor.My SPI has successfully enlimited warnings of
withXXX
accessors. but in my IDEA, it still promotes the hits for addingwithXXX
mappings:The text was updated successfully, but these errors were encountered: