Update for latest changes of the SSSOM schema #552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `semantic_similarity_score` slot (and the accompanying `semantic_similarity_measure` slot) has recently been renamed to `similarity_score` in the tip of the master branch in the sssom-schema repository. That renaming causes the `TestUtils::test_get_dict_from_mapping` test to fail, because that test expects that a mapping constructed from a dictionary will contain `semantic_similarity_*` slots, which will not be the case with newer version of the schema. We update that test to automatically detect whether the SSSOM schema defines a `semantic_similarity_score` slot (by looking at the auto-generated `slots` class) and change its expectations consequently. That way the test will work as expected regardless of the version of the SSSOM schema we are testing against.
The SSSOM schema will soon no longer define the `subject_id` slot as being inconditionally required. Instead, it will only be required iff `subject_type` is not set to `rdfs literal`; if `subject_type` is set to `rdfs literal`, it is `subject_label` that will be required instead. Unfortunately, even though this variable constraint is formally expressed in the SSSOM schema, the generated Python constructor does not enforce it, and simply treat `subject_id` as a non-required slot. This means that we can no longer rely on the Mapping constructor to correctly flag mappings with a missing `subject_id`. Instead, we need to perform a post-constructor validation by manually looking at `subject_id` and `subject_type`. This is what we do here. (All the above also applies, mutatis mutandis, to `object_id`.)
9 tasks
matentzn
reviewed
Aug 8, 2024
matentzn
reviewed
Aug 8, 2024
Collaborator
matentzn
left a comment
matentzn
left a comment
There was a problem hiding this comment.
Awesome, I didnt believe you would even touch sssom-py!! Much much much appreciated!!
Contributor
Author
Not that I like that (you know my opinion on Python… right? :p ), but I am the one who pushed for this method of representing literal mappings, so the least I can do is help sorting the resulting issues. |
matentzn
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates SSSOM-Py to prepare it for changes that either have already occurred or that will occur in the SSSOM schema:
semantic_similarity_{score|measure}slots have been renamed tosimilarity_{score|measure};subject_idandobject_idslots will no longer be unconditionally required, but instead will be required or not depending on the value ofsubject_typeandobject_type(something the generated Python class is unfortunately unable to enforce on its own, despite the properrulesexpressed in the schema).