Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo: Migrate to yarn #770

Merged
merged 2 commits into from
Jul 17, 2023
Merged

Demo: Migrate to yarn #770

merged 2 commits into from
Jul 17, 2023

Conversation

nyurik
Copy link
Member

@nyurik nyurik commented Jul 17, 2023

npm install is having some weird issues, while yarn seem to work well. Also, bumped almost all dependencies.

@nyurik nyurik requested a review from birkskyum July 17, 2023 04:52
Copy link
Member

@birkskyum birkskyum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this run, or is an extra initial step to install yarn needed in the Dockerfile?

`npm install` is having some weird issues, while `yarn` seem to work well. Also, bumped almost all dependencies.
@nyurik
Copy link
Member Author

nyurik commented Jul 17, 2023

@birkskyum apparently yarn is already included in the docker node image. I updated it to the latest just in case.

@nyurik nyurik enabled auto-merge (squash) July 17, 2023 17:52
@nyurik nyurik disabled auto-merge July 17, 2023 18:27
@nyurik nyurik merged commit 6d17c1e into maplibre:main Jul 17, 2023
@nyurik nyurik deleted the bump-demo-deps branch July 17, 2023 18:27
lefuturiste pushed a commit to lefuturiste/martin that referenced this pull request Aug 26, 2024
`npm install` is having some weird issues, while `yarn` seem to work
well. Also, bumped almost all dependencies.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants