Enable background location updates on AppleLocationEngine #166
Conversation
| LocationEngine { | ||
|
|
||
| constructor() : this(getLocationTimeout = 5.seconds) | ||
| constructor() : this(getLocationTimeout = 5.seconds, enableBackgroundLocationUpdates = true) |
There was a problem hiding this comment.
Should the default be true? Or if the user has not provided the permissions, will there just be no updates when the screen is locked?
There was a problem hiding this comment.
I recon for most navigation apps, background location updates are a good thing.
If the the proper background mode is not declared in the Info.plist, the app will crash.
https://developer.apple.com/documentation/corelocation/cllocationmanager/allowsbackgroundlocationupdates
There was a problem hiding this comment.
I think also, that is a common use case for navigation apps.
If you don't like it @boldtrn, we can think about a README note for iOS setup.
There was a problem hiding this comment.
Ok, I am fine either way, we can add it to the Readme or just enable this by default. It's important that his does not crash the app, if everything is configured the right way.
There was a problem hiding this comment.
| # | App wants BG updates? | Info.plist declares UIBackgroundModes = location |
CLLocationManager .allowsBackgroundLocationUpdates |
Runtime outcome |
|---|---|---|---|---|
| 1 | No | No | No | Works, foreground-only |
| 2 | No | No | Yes | 💥 Crash (fatal error) |
| 3 | No | Yes | No | Works, foreground-only |
| 4 | No | Yes | Yes | Gets background updates (wasted battery) |
| 5 | Yes | No | No | Runs, but no BG updates |
| 6 | Yes | No | Yes | 💥 Crash (fatal error) |
| 7 | Yes | Yes | No | Runs, but no BG updates |
| 8 | Yes | Yes | Yes | ✅ Current PR solution |
There was a problem hiding this comment.
So a resonable default depends what's the default expectation of the app.
If we assume the app doesn't need background location updates, a better approach is NOT to enable them by default.
If we assume the app does need background location updates, it's better to enable them.
There was a problem hiding this comment.
Ok sure, let's enable it 👍
|
Please remember to add a changelog and increase the version number I'd say? |
|
My magic is no good here, tho ;) Could someone please hit the green button? 🙇 |
|
🪄 🧙 win gar dium levi ohhh sa |
3 participants
No description provided.