Document how to avoid non-free dependencies on Android #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wipfli
reviewed
Jun 8, 2022
There was a problem hiding this comment.
Looks like a good idea to me, thanks. @maxammann can you maybe comment if this is correct?
wipfli
approved these changes
Jun 16, 2022
|
Looks good to me! Maybe we should add another example though for Flutter and React Native. Both do not allow to exclude a dependency like that because the list of dependencies are generated automatically. |
keith
pushed a commit
to lyft/maplibre-gl-native
that referenced
this pull request
Jul 22, 2022
* Document how to avoid non-free dependencies on Android * Replace explicit version number with placeholder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given #288 was closed with the decision to not provide an explicit libre flavor because excluding the non-free dependencies is very simple, I am hoping documenting it like this should help users be aware that this is an option.
Thanks for considering :)