Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include macOS binaries in XCFramework #5

Closed
chrisballinger opened this issue Jan 16, 2021 · 4 comments
Closed

Include macOS binaries in XCFramework #5

chrisballinger opened this issue Jan 16, 2021 · 4 comments

Comments

@chrisballinger
Copy link

The existing XCFramework you're distributing could be expanded to include the macOS platform alongside iOS and iOS Simulator (and Mac Catalyst)
@petr-pokorny-1
Copy link
Contributor

The SDK for MacOS has different APIs than SDK for iOS. I am not sure but I think slices in XCFramework should have the same APIs for all supported platforms.

@chrisballinger
Copy link
Author

If it's significantly different for AppKit than maybe it's worth distributing separately, however, Mac Catalyst would have the same API as the iOS builds

@roblabs
Copy link
Collaborator

roblabs commented Feb 21, 2021

While building for Mac Catalyst using MapLibre v5.10.0:

Current error is

While building for Mac Catalyst, no library for this platform was found in '/Users/roblabs/Library/Developer/Xcode/DerivedData/openmaptiles-ios-demo-btjolluihnwewhdsquzewzkiemgj/SourcePackages/artifacts/maplibre-gl-native/Mapbox.xcframework'.

The path .../SourcePackages/artifacts/maplibre-gl-native/ is where the Swift Packages artifacts are downloaded to.

Test App settings:

image

@petr-pokorny-1
Copy link
Contributor

Mac Cataylist is tracked under #3
Closing.

nvanfleet referenced this issue in lyft/maplibre-gl-native Jul 28, 2022
@lyft-control-2
Update parent bionicbase to current version (#5)
0bd8710 
This PR is updating the version of this image's parent (`bionicbase`) to keep this image (`maplibreglnativeprivate`) up-to-date.
It will be merged if all tests pass via `/merge-skip-owners`; if tests do not pass, it will require manual intervention.

For more details please see the [docs about Automatic Updates](https://docs.lyft.net/eng/provisioningdocs/learning/automatic_updates.html).

[Here is what's changed in `bionicbase`](lyft/containers@c6be0ea...126a7a7).

REVIEWS WERE BYPASSED
louwers pushed a commit that referenced this issue Mar 1, 2023
@matkoniecz
direct to issues in this repo, not forked one (#5)
bad245e
TimSylvester pushed a commit to WetDogWeather/maplibre-gl-native that referenced this issue Sep 8, 2023
@stefankarschti
Merge pull request maplibre#5 from WetDogWeather/drawable-perf-fix-ot…
39079e6 
…her-styles

Include render tree setup in frame time, use `util::MonotonicTimer`.
This was referenced Oct 18, 2023
Merged
Merged
Merged
Merged
Closed
Merged
@sjg-wdw sjg-wdw mentioned this issue Apr 30, 2024
Open
@louwers louwers mentioned this issue May 7, 2024
Closed
@louwers louwers mentioned this issue May 27, 2024
Closed
@sjg-wdw sjg-wdw mentioned this issue May 29, 2024
Open
@nijs9 nijs9 mentioned this issue Oct 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@roblabs @chrisballinger @petr-pokorny-1