Windows Support (#735) #795
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D29959025 |
|
@pierotofy we're on the verge of merging it. What's the purpose of the |
|
The OpenCV python bindings ( If we don't want to explicitly include this in the requirements.txt, we can always just add an install step in the docs to tell people to install opencv-python separately on Windows. |
YanNoun
pushed a commit
to YanNoun/OpenSfM
that referenced
this pull request
Sep 20, 2021
Summary: Pull Request resolved: mapillary#795 Hello ✋ This PR gets OpenSfM to compile and run on Windows! The main points that have been addressed: - [x] Rewrote the memory functions in `context.py` to work on all three platforms (Windows, Mac, Linux). This adds a new small dependency (`vmem`). - [x] Added a `bin/opensfm.bat` script for invoking the program. - [x] Some minor compilation issues related to Visual Studio are addressed. The definition of `M_PI` is a bit.. hackish, but the alternative is to include: ``` #define _USE_MATH_DEFINES #include <cmath> ``` In a lot of places where M_PI is referenced. I'm not sure that's better (but I can change it if you want). I'm also unsure of what side effects the `_USE_MATH_DEFINES` macro might do. 💣 - [x] Updated the docs with build instructions for Windows. - [x] Installs `opencv-python` as a pip dependency on Windows only; this is because vcpkg builds of OpenCV don't provide a version with OpenCV's Python bindings. This only affects Windows environments (it won't install on Mac or Linux). I hope this can be useful to others. Pull Request resolved: mapillary#735 Reviewed By: paulinus Differential Revision: D29959025 Pulled By: YanNoun fbshipit-source-id: df5f3a8701552f44e35b89657f3a68101214ce2f
YanNoun
force-pushed
the
export-D29959025
branch
from
c38700e to
f1aa704
Compare
|
This pull request was exported from Phabricator. Differential Revision: D29959025 |
Summary: This Diff adds the ability to set the GCPs default horizontal and vertical accuracy from the `config.yaml` We also added the corresponding check in the incremental reconstruction test. Differential Revision: D30963281 fbshipit-source-id: d77b952f689ce87120eef5187077b694ce414bcf
Summary: Pull Request resolved: mapillary#795 Hello ✋ This PR gets OpenSfM to compile and run on Windows! The main points that have been addressed: - [x] Rewrote the memory functions in `context.py` to work on all three platforms (Windows, Mac, Linux). This adds a new small dependency (`vmem`). - [x] Added a `bin/opensfm.bat` script for invoking the program. - [x] Some minor compilation issues related to Visual Studio are addressed. The definition of `M_PI` is a bit.. hackish, but the alternative is to include: ``` #define _USE_MATH_DEFINES #include <cmath> ``` In a lot of places where M_PI is referenced. I'm not sure that's better (but I can change it if you want). I'm also unsure of what side effects the `_USE_MATH_DEFINES` macro might do. 💣 - [x] Updated the docs with build instructions for Windows. - [x] Installs `opencv-python` as a pip dependency on Windows only; this is because vcpkg builds of OpenCV don't provide a version with OpenCV's Python bindings. This only affects Windows environments (it won't install on Mac or Linux). I hope this can be useful to others. Pull Request resolved: mapillary#735 Reviewed By: paulinus Differential Revision: D29959025 Pulled By: YanNoun fbshipit-source-id: b79e2c7355200d86b01eb8504169a03034fda7a6
YanNoun
force-pushed
the
export-D29959025
branch
from
f1aa704 to
7a390e8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D29959025 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Hello ✋
This PR gets OpenSfM to compile and run on Windows!
The main points that have been addressed:
context.pyto work on all three platforms (Windows, Mac, Linux). This adds a new small dependency (vmem).bin/opensfm.batscript for invoking the program.M_PIis a bit.. hackish, but the alternative is to include:In a lot of places where M_PI is referenced. I'm not sure that's better (but I can change it if you want). I'm also unsure of what side effects the
_USE_MATH_DEFINESmacro might do. 💣opencv-pythonas a pip dependency on Windows only; this is because vcpkg builds of OpenCV don't provide a version with OpenCV's Python bindings. This only affects Windows environments (it won't install on Mac or Linux).I hope this can be useful to others.
Pull Request resolved: #735
Differential Revision: D29959025
Pulled By: YanNoun