-
Notifications
You must be signed in to change notification settings - Fork 216
v1.0.2 draft #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.0.2 draft #36
Conversation
1.0.2-draft/README.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
must directly follow the exterior ring they belong too
typo? "belong to"
|
This looks good to me. 👍 |
|
Flyby comment.... What's the suggested format for the raster data? And is that info supposed to be encoded in the tags? |
…e spec a little with more sections.
|
The improvements make sense 👍 |
Clarify Winding Order
1.0.2-draft/README.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For polygons a repeated
move_towill indicate either either another exterior of a new polygon part or an interior ring of of the previous polygon part.
In the fourth sentence, should either either and of of just be one either and one of?
|
Just wondering — should we also mention that polygon geometries need to be strictly simple? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SHOULD be clipped, reprojected into spherical mercator
Geometries are stored as graphics in the tiles, as they are projected, clipped and converted to screen coordinates.
The client doesn't have to know about what projection the geometries were before that process, as it consumes only the final screen coordinates.
I wouldn't word this as SHOULD IMO
|
This pull request have been closed with out merging due to the new version 2 pull request #39 |
v1.0.2 proposed
rasterproperty on feature/cc @mourner @jfirebaugh for review.