Skip to content

Conversation

@springmeyer
Copy link

v1.0.2 proposed

  • Clarifies winder order expectation for polygons
  • Adds raster property on feature

/cc @mourner @jfirebaugh for review.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

must directly follow the exterior ring they belong too

typo? "belong to"

@mourner
Copy link
Member

mourner commented Oct 19, 2015

This looks good to me. 👍

@paulmach
Copy link

Flyby comment.... What's the suggested format for the raster data? And is that info supposed to be encoded in the tags?

@ycabon
Copy link

ycabon commented Oct 23, 2015

The improvements make sense 👍

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For polygons a repeated move_to will indicate either either another exterior of a new polygon part or an interior ring of of the previous polygon part.

In the fourth sentence, should either either and of of just be one either and one of?

@mourner
Copy link
Member

mourner commented Oct 26, 2015

Just wondering — should we also mention that polygon geometries need to be strictly simple?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SHOULD be clipped, reprojected into spherical mercator

Geometries are stored as graphics in the tiles, as they are projected, clipped and converted to screen coordinates.
The client doesn't have to know about what projection the geometries were before that process, as it consumes only the final screen coordinates.
I wouldn't word this as SHOULD IMO

@flippmoke
Copy link
Member

This pull request have been closed with out merging due to the new version 2 pull request #39

@springmeyer springmeyer deleted the v1.0.2.-draft branch October 26, 2017 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants