Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bounds #39

Merged
merged 2 commits into from
May 8, 2018
Merged

bounds #39

merged 2 commits into from
May 8, 2018

Conversation

mapsam
Copy link
Contributor

@mapsam mapsam commented May 4, 2018

This adds the bounds field to the Structure section, and includes some added text (in bold) from the current description:

The maximum extent of available map tiles. Bounds MUST define an area covered by all zoom levels. The bounds are represented in WGS:84 latitude and longitude values, in the order left, bottom, right, top. Values may be integers or floating point numbers. The minimum/maximum values for longitude and latitude are -180/180 and -90/90 respectively. Bounds MUST NOT "wrap" around the ante-meridian. If bounds are not present, the default value assumes the set of tiles is globally distributed.

The new addition covers questions from #25 and #23 at least for the v3 perspective, but they could be redefined in v4

cc @GretaCB

@mapsam mapsam changed the base branch from master to 3.0 May 4, 2018 20:41
@GretaCB
Copy link
Contributor

GretaCB commented May 4, 2018

@mapsam

If bounds are not present, the default value assumes the set of tiles is globally distributed.

Per #37 (comment), should this specify MAY assume...?

@mapsam
Copy link
Contributor Author

mapsam commented May 4, 2018

@GretaCB yes! Changing to

If bounds are not present, the default value MAY assume the set of tiles is globally distributed.

@mapsam mapsam mentioned this pull request May 7, 2018
41 tasks
@GretaCB
Copy link
Contributor

GretaCB commented May 8, 2018

If bounds are not present, the default value assumes the set of tiles is globally distributed.

@mapsam Per the default value convo, how bout...

If bounds are not present, the default value MAY assume the set of tiles is globally distributed.

@GretaCB
Copy link
Contributor

GretaCB commented May 8, 2018

oh my goodness, de ja vous. Please disregard the comment above @mapsam . Seeing it was addressed per #39 (comment)

@mapsam
Copy link
Contributor Author

mapsam commented May 8, 2018

@GretaCB no worries! A good reminder that including the text in the initial comment isn't terribly helpful after making updates 😄

@mapsam mapsam merged commit 4c6d3e1 into 3.0 May 8, 2018
@mapsam mapsam deleted the 3.0-bounds branch May 8, 2018 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants