Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update lockfile #836

Merged
merged 1 commit into from
Jul 4, 2024
Merged

update lockfile #836

merged 1 commit into from
Jul 4, 2024

Conversation

benmccann
Copy link
Collaborator

update from lockfile version 2 to version 3

@striezel
Copy link
Contributor

striezel commented Jul 3, 2024

It's probably a good idea to wait for all (or at least most) of those open dependabot pull requests to get merged before these changes get merged. Otherwise dependabot might rebase its open pull requests, and that will trigger a lot of CI re-runs. That's probably okay for builds on GitHub Actions, but the AppVeyor builds usually take a while, at least in my experience.

@benmccann
Copy link
Collaborator Author

I think the more likely outcome is that it would close the majority of the pending PRs as being no longer necessary since those PRs only affect the lockfile and this PR updates the lockfile. I think it's better to handle them in one go like this or like rennovate bot does than to do 50 individual PRs that just clog up the PR queue and commit log

@cclauss cclauss merged commit 8edf1cc into mapbox:master Jul 4, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants