-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace npmlog
with consola
#829
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing! Thank you!!
@br0p0p would you be able to fix the merge conflict? |
@benmccann done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm except that it looks like the appveyor tests might be failing
@cclauss could you kick off the github actions tests on this PR?
@br0p0p I'm afraid all the CI jobs are failing with this PR. would you be able to take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hoping this gets merged soon. Thank you for your work! 🍻 |
THANK YOU @br0p0p! appreciate you sticking with it during this long wait to get it merged. now hopefully we can get it released too! |
This PR replaces the deprecated and dependency-laden
npmlog
with a smaller, modern alternative:consola
.npmlog
consola
Extrapolating based on the download stats for
@mapbox/node-pre-gyp
(5,730,435 downloads per week), this migration will have the following effects on the ecosystem as a whole:package-size-calculator
outputI will note that the output looks slightly different with these changes. Happy to update if the new format is not great
Before
After