Remove dependency on hawk, upgrade request#347
Remove dependency on hawk, upgrade request#347springmeyer merged 1 commit intomapbox:masterfrom krotscheck:hawk
Conversation
|
The only mention of hawk appears to be the package.json file: |
|
The package request@2.81.0 depends on Updating to |
|
@SebastianSchmidt Done. Jetzt auf Travis warten ⏳ |
This patch removes the explicit dependency on hawk, and upgrades request to the newest version. It also removes node 0.10 from the testing grid, as this version has been EOL'd by the node foundation, and doesn't support es6 syntax used in the newer introduced dependencies. https://nodesecurity.io/advisories/566 https://hackerone.com/reports/310439 https://github.com/nodejs/Release Closes #346
|
Yeah, saw that. Given that node 0.10 is EOL, I removed it from the testing grid. |
|
@springmeyer Any chance you can take a look at this? |
|
Would be great to have this PR merged in -- any updates? 🙂 |
|
Any updates on this? |
Waiting for mapbox/node-pre-gyp#347
Waiting for mapbox/node-pre-gyp#347
|
Any updates on this? We need the merge ASAP! |
|
Whoops, just saw this PR. I also made a PR to address this, #349. Many packages are waiting on this so it can go upstream. |
|
Yeah, waiting too. Does node-pre-gyp only have a single maintainer? |
|
Merging this PR and releasing a new version would be great! :) |
|
Thanks for this PR. Sorry for the wait in review/merging. Will merge now and release as |
|
node-pre-gyp@0.7.0 is now published: https://www.npmjs.com/package/node-pre-gyp |
* This commit still doesn't pass volnurability check. But it will be solved soon enough * refs: mapbox/node-pre-gyp#347
Remove dependency on hawk, upgrade request
This patch removes the explicit dependency on hawk, and upgrades request
to the newest version. It also removes node 0.10 from the testing grid,
as this version has been EOL'd by the node foundation, and doesn't support
es6 syntax used in the newer introduced dependencies.
https://nodesecurity.io/advisories/566
https://hackerone.com/reports/310439
https://github.com/nodejs/Release
Closes #346