Skip to content

Conversation

@hannesj
Copy link
Contributor

@hannesj hannesj commented Sep 28, 2016

As getTile swaps the z-coordinate from tms to xyz

Fixes #65

As getTile swaps the z-coordinate from tms to xyz
hannesj added a commit to HSLdevcom/hsl-map-server that referenced this pull request Sep 28, 2016
@jingsam
Copy link
Collaborator

jingsam commented Mar 26, 2018

ping @mapsam

@mapsam
Copy link
Contributor

mapsam commented Mar 26, 2018

@flippmoke can you confirm this is 👍? Since you just want to confirm since you recently updated the mbtiles specification.

@jingsam
Copy link
Collaborator

jingsam commented Aug 4, 2018

ping @mapsam

@mapsam
Copy link
Contributor

mapsam commented Aug 6, 2018

@jingsam thanks for the ping again- I've been hesitant to merge this only for the sake of being unsure about the downstream ramifications of switching this over. Should/does the scheme field represent the user expectations of the tileset (in which case zxy makes sense), or does it represent the internals of the MBTiles format (in which tms is the spec)? I'm unsure of how downstream tools may respond to the field, any experience here?

@hannesj
Copy link
Contributor Author

hannesj commented Aug 8, 2018

Based on my understanding, the metadata should reflect what the tilelive api responds with. The internal storage within the mbtiles is just a implementation detail for the tilelive interface. I created this PR for us to be able to render tiles properly with https://github.com/mojodna/tessera

@jingsam
Copy link
Collaborator

jingsam commented Apr 15, 2019

@mapsam I agree with @hannesj . scheme should be tms in metadata table to represent the internal of the MBTiles format. However, when users retrieve information form getInfo interface, the scheme should represent tile service scheme, which always be xyz.

@mapsam
Copy link
Contributor

mapsam commented Apr 15, 2019

@jingsam @hannesj 👍 let's do it.

@jingsam
Copy link
Collaborator

jingsam commented Apr 16, 2019

@hannesj I think putInfo should also write scheme: tms into metadata table. Would you mind revise your PR and add some test?

@jingsam jingsam merged commit 7fd30ff into mapbox:master May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistent scheme in getInfo

3 participants