Fix sine xcode 14 warnings #3989
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S2Ler
added
the
op-ex
Breaking Changes in MapboxCoreNavigationBreaking API Changes
|
| Type of change: | Access Level |
|---|---|
| From: | open |
| To: | public |
calculateOffline(options:completionHandler:)
- modified method:
calculateOffline(options:completionHandler:)Type of change: Access Level From: openTo: public
calculateWithCache(options:completionHandler:)
- modified method:
calculateWithCache(options:completionHandler:)Type of change: Access Level From: openTo: public
isMotorway
- modified var:
isMotorwayType of change: Access Level From: openTo: public
MaximAlien
reviewed
Jul 6, 2022
MaximAlien
approved these changes
Jul 6, 2022
S2Ler
force-pushed
the
s2ler/fix-xcode-14-warnings
branch
from
903bf8c to
e9fc283
Compare
This is not a breaking change. |
Breaking Changes in MapboxCoreNavigationBreaking API Changes
|
| Type of change: | Access Level |
|---|---|
| From: | open |
| To: | public |
isMotorway
- modified var:
isMotorwayType of change: Access Level From: openTo: public
calculateWithCache(options:completionHandler:)
- modified method:
calculateWithCache(options:completionHandler:)Type of change: Access Level From: openTo: public
calculateOffline(options:completionHandler:)
- modified method:
calculateOffline(options:completionHandler:)Type of change: Access Level From: openTo: public
azarovalex
approved these changes
Jul 15, 2022
S2Ler
force-pushed
the
s2ler/fix-xcode-14-warnings
branch
from
e9fc283 to
5e2cdde
Compare
Breaking Changes in MapboxCoreNavigationBreaking API Changes
|
| Type of change: | Access Level |
|---|---|
| From: | open |
| To: | public |
calculateWithCache(options:completionHandler:)
- modified method:
calculateWithCache(options:completionHandler:)Type of change: Access Level From: openTo: public
lastInstruction
- modified var:
lastInstructionType of change: Access Level From: openTo: public
isMotorway
- modified var:
isMotorwayType of change: Access Level From: openTo: public
MaximAlien
pushed a commit
that referenced
this pull request
Sep 6, 2022
thanhminhkma
pushed a commit
to thanhminhkma/mapbox-navigation-ios
that referenced
this pull request
Sep 14, 2022
…n extension (mapbox#3989) (cherry picked from commit 793a34f)
thanhminhkma
pushed a commit
to thanhminhkma/mapbox-navigation-ios
that referenced
this pull request
Sep 14, 2022
(cherry picked from commit 2dc7c17)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The warnings say that you can't override methods/properties that are declared in an extension. That means there is no reason to mark methods as open.