Remove NavigationCamera ProgressChangeListener as public api #828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guardiola31337
approved these changes
Apr 6, 2018
There was a problem hiding this comment.
#826 is a great example of why we always should be really careful of what we expose publicly. This reminds me to 👇
Classes are private until the opposite is proved.
😂
Minor comments not blocking the PR, other than that 🚀
| * @param location used to update the camera position | ||
| * @param routeProgress ignored in this scenario | ||
| */ | ||
| ProgressChangeListener progressChangeListener = new ProgressChangeListener() { |
There was a problem hiding this comment.
NIT Could we move this up with the rest of the variables?
|
|
||
| import static junit.framework.Assert.assertFalse; | ||
| import static junit.framework.Assert.assertNotNull; | ||
| import static junit.framework.Assert.assertTrue; | ||
| import static org.mockito.Mockito.times; | ||
| import static org.mockito.Mockito.verify; | ||
|
|
||
| @RunWith(RobolectricTestRunner.class) | ||
| @Config(constants = BuildConfig.class, manifest = Config.DEFAULT_MANIFEST_NAME) | ||
| public class NavigationCameraTest { |
There was a problem hiding this comment.
NIT This is a great opportunity to refactor the tests 🎉
In general, we should avoid inline setup 👀 https://speakerdeck.com/guardiola31337/elegant-unit-testing-mobilization-2016?slide=65
Could you remove navigation and mapboxMap mock variables and extract
private "factory" method called for example setupCamera and use it across the tests?IMO, it reflects better what's going on in the test and you don't break the triple A "rule".
danesfeder
force-pushed
the
dan-nav-cam-listener
branch
from
9185567
to
f4b1c46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #826