Fix OffRoute detection disabled bug #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guardiola31337
approved these changes
Mar 22, 2018
| @@ -70,6 +69,39 @@ public void defaultEngines_didGetInitialized() throws Exception { | |||
| assertNotNull(navigation.getOffRouteEngine()); | |||
| } | |||
|
|
|||
| @Test | |||
| public void offRouteEngine_doesNotGetInitializedWithFalseOption() throws Exception { | |||
There was a problem hiding this comment.
Normally is good to structure the tests following the triple A 👀 https://speakerdeck.com/guardiola31337/elegant-unit-testing-mobilization-2016?slide=40 http://wiki.c2.com/?ArrangeActAssert
If the Arrange part gets too long we should create factory or builder methods.
This applies to other tests included in MapboxNavigationTest.
| navigation = new MapboxNavigation(mock(Context.class), ACCESS_TOKEN, options, mock(NavigationTelemetry.class), | ||
| mock(LocationEngine.class)); | ||
| assertNull(navigation.getOffRouteEngine()); | ||
| initDefaultNavigation(); |
There was a problem hiding this comment.
Why is initDefaultNavigation() needed?
👀 FIRST
|
|
||
| List<Milestone> triggeredMilestones | ||
| = checkMilestones(routeProgress, routeProgress, mapboxNavigation); | ||
| assertEquals(1, triggeredMilestones.size()); |
There was a problem hiding this comment.
Generally is preferable having only 1 assertion per test 👀 https://speakerdeck.com/guardiola31337/elegant-unit-testing-mobilization-2016?slide=57
danesfeder
force-pushed
the
dan-off-route-bug
branch
from
1187e00
to
f71b5d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #780