Add bearing to RouteEngine requests #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danesfeder
force-pushed
the
dan-bearing-faster-route
branch
from
6ca166a
to
0e6781d
Compare
|
@devotaaabel @Guardiola31337 this is ready for 👀 |
ericrwolfe
approved these changes
Feb 15, 2018
danesfeder
force-pushed
the
dan-bearing-faster-route
branch
from
0e6781d
to
bea6fef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Faster route requests are not taking bearing into account. Our checks should prevent a route like this from being fired to the listener, but this can lead to routes showing up going into the opposite direction, causing an immediate reroute.
TODO: