Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SSML parameter to Polly request #612

Merged
merged 1 commit into from
Dec 18, 2017
Merged

Add SSML parameter to Polly request #612

merged 1 commit into from
Dec 18, 2017

Conversation

danesfeder
Copy link
Contributor

Allows proper processing of SSML tags in the text instruction from the Directions API

@danesfeder danesfeder added the bug Defect to be fixed. label Dec 18, 2017
@danesfeder danesfeder added this to the v0.8.0 milestone Dec 18, 2017
@danesfeder danesfeder self-assigned this Dec 18, 2017
ericrwolfe
ericrwolfe approved these changes Dec 18, 2017
View reviewed changes
Copy link
Contributor

@ericrwolfe ericrwolfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the related PR that introduced this bug (switching from raw text to the ssml text)?

@danesfeder
Copy link
Contributor Author

Yeah #584 - oversight on my part using the test app / only checking the listener with SSML was firing properly

@danesfeder danesfeder merged commit eee1b29 into master Dec 18, 2017
@danesfeder danesfeder deleted the dan-polly-ssml-fix branch December 18, 2017 18:00
@danesfeder danesfeder mentioned this pull request Dec 20, 2017
Closed
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericrwolfe ericrwolfe ericrwolfe approved these changes

@cammace cammace Awaiting requested review from cammace

Assignees

@danesfeder danesfeder

Labels
bug Defect to be fixed.
Projects
None yet
Milestone
v0.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@danesfeder @ericrwolfe