Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate subscriptions to the ViewModels #583

Merged
merged 1 commit into from
Dec 11, 2017
Merged

Remove duplicate subscriptions to the ViewModels #583

merged 1 commit into from
Dec 11, 2017

Conversation

danesfeder
Copy link
Contributor

  • ViewModels are being subscribed to twice, causing unnecessary updates / cancelling animations in the LocationLayerPlugin

cc @ericrwolfe

@danesfeder danesfeder added the bug Defect to be fixed. label Dec 11, 2017
@danesfeder danesfeder self-assigned this Dec 11, 2017
@danesfeder danesfeder merged commit 2a4b7e0 into master Dec 11, 2017
@danesfeder danesfeder deleted the dan-duplicate-subscribes branch December 11, 2017 16:56
@danesfeder danesfeder mentioned this pull request Dec 20, 2017
Closed
15 tasks
@danesfeder danesfeder mentioned this pull request Sep 13, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cammace cammace cammace approved these changes

@Guardiola31337 Guardiola31337 Awaiting requested review from Guardiola31337

Assignees

@danesfeder danesfeder

Labels
bug Defect to be fixed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danesfeder @cammace