Update distance completed in off route scenario #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericrwolfe
reviewed
Dec 5, 2017
| @@ -110,6 +110,7 @@ public void onRouteProgressUpdate(RouteProgress routeProgress) { | |||
|
|
|||
| @Override | |||
| public void onOffRouteEvent(Location offRouteLocation) { | |||
| updateDistanceCompleted(); | |||
| isOffRoute = true; | |||
There was a problem hiding this comment.
Since we're setting isOffRoute = true here, do we want to add a guard at the top checking isOffRoute == false and returning early, so we don't accidentally call updateDistanceCompleted() and queueRerouteEvent() again if onOffRouteEvent is ever called more than once?
There was a problem hiding this comment.
Yeah good call -- will add and merge
ericrwolfe
approved these changes
Dec 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.