Add custom notification support #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danesfeder
added
feature
danesfeder
force-pushed
the
dan-custom-notification
branch
from
1aa9dca
to
3f495ee
Compare
danesfeder
force-pushed
the
dan-custom-notification
branch
from
3f495ee
to
c677c75
Compare
|
Simple custom example added to the test app:
|
danesfeder
added
✓ ready for review
and removed
⚠️ DO NOT MERGE
cammace
approved these changes
Dec 8, 2017
|
Seeing an issue with custom notifications in Android O - still need to investigate |
danesfeder
added
⚠️ DO NOT MERGE
|
Resolved the issue above in f95a016 Custom notifications in Android O will need to either create a custom channel before passing to the SDK or will need to use the channel we create. This will be outlined in the notification docs |
This was referenced Dec 18, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #485
ForegroundServicewhile navigation is running, we must setup a notification for Android O and above (see ANR/Crash on Android 8 when notification is not enabled #485).