Cancel notification when service is destroyed #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fication button is clicked
danesfeder
changed the title
ericrwolfe
approved these changes
Oct 25, 2017
cammace
approved these changes
Oct 25, 2017
Grsmto
pushed a commit
to Grsmto/mapbox-navigation-android
that referenced
this pull request
Oct 27, 2017
…android into fix-build * 'master' of https://github.com/mapbox/mapbox-navigation-android: Adjust API Milestone to handle new routes (mapbox#425) Cancel notification when the service is destroyed, not just when notification button is clicked (mapbox#409) adds validation utils class (mapbox#424) Wait for map style to load before initializing run time styling (mapbox#423) Changed up NavigationRoute (mapbox#413) # Conflicts: # libandroid-navigation/src/main/java/com/mapbox/services/android/navigation/v5/navigation/NavigationRoute.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cancel notification when the service is destroyed, not just when notification button
End Navigationis clicked