Simplify will voice API #1281
Merged
Simplify will voice API #1281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danesfeder
approved these changes
Sep 11, 2018
There was a problem hiding this comment.
Thanks @Guardiola31337 - let's make sure we update the Android docs site as well with these changes 👍
Very true, this is breaking SemVer. Thanks for the reminder 🙏 |
danesfeder
added
the
backwards incompatible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per our discussion in #1233 (comment) this PR unblocks the voice instructions work from #1233 allowing us to rethink the display portion and decide the intended functionality separately.
willVoiceAPI