Update NavigationView to guard against duplicate initializations #1247
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims addresses the original issue found in #1209 and removes the immediate need for #1239
In the
NavigationView
we were saying theView
was "initialized" when navigation started. I think it makes more sense to check ifNavigationMapboxMap
is initialized and then haveNavigationViewModel
be the single source of truth for running navigation.This should ensure 1
NavigationMapboxMap
per 1NavigationView
. Creating more than one map per view was the issue I believe with the instrumentation tests.