Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NavigationView to guard against duplicate initializations #1247

Merged
merged 1 commit into from
Aug 29, 2018

Conversation

danesfeder
Copy link
Contributor

@danesfeder danesfeder commented Aug 29, 2018

This PR aims addresses the original issue found in #1209 and removes the immediate need for #1239

In the NavigationView we were saying the View was "initialized" when navigation started. I think it makes more sense to check if NavigationMapboxMap is initialized and then have NavigationViewModel be the single source of truth for running navigation.

This should ensure 1 NavigationMapboxMap per 1 NavigationView. Creating more than one map per view was the issue I believe with the instrumentation tests.

@danesfeder danesfeder added bug Defect to be fixed. ✓ ready for review labels Aug 29, 2018
@danesfeder danesfeder self-assigned this Aug 29, 2018
Copy link
Contributor

@Guardiola31337 Guardiola31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, good point! Thanks for the quick fix here @danesfeder 🙏

Noting that this would resolve part of #1209 specifically the crash originated from our side CannotAddSourceException. We should keep digging into how to mitigate the other ones. Should we keep #1209 opened then? FWIW those happen rarely / less often.

@danesfeder
Copy link
Contributor Author

@Guardiola31337 I updated, but did not close #1209 until we figure out the other issues. Looks like related to the Directions API request we do when starting up the test each time.

@danesfeder danesfeder merged commit 7a092a5 into master Aug 29, 2018
@danesfeder danesfeder deleted the dan-fix-orientation branch August 29, 2018 13:08
@Guardiola31337
Copy link
Contributor

I updated, but did not close #1209 until we figure out the other issues.

Awesome, thanks!

Looks like related to the Directions API request we do when starting up the test each time.

Yeah, looks like it. Wondering if internet connection and/or using specific devices could be the cause of the issues 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Defect to be fixed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants