Custom Instructions for Milestones #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cammace this is ready for a first round of 👀 |
cammace
reviewed
Jul 11, 2017
| @@ -102,12 +107,16 @@ public MapboxNavigation(@NonNull Context context, @NonNull String accessToken, | |||
| offRouteListeners = new CopyOnWriteArrayList<>(); | |||
| milestoneEventListeners = new CopyOnWriteArrayList<>(); | |||
| milestones = new CopyOnWriteArrayList<>(); | |||
| addDefaultMilestones(); | |||
|
|
|||
| if (!options.defaultInstructionsDisabled()) { | |||
There was a problem hiding this comment.
Let's make this option defaultMilestonesEnabled()
| * | ||
| * @since 0.4.0 | ||
| */ | ||
| public class DepartureInstruction extends Instruction { |
There was a problem hiding this comment.
Rather than create separate files for each class, why not build these instructions directly in mapboxNavigation near the milestone creation.
danesfeder
force-pushed
the
dan-custom-instruction
branch
from
b74fa9b
to
60d4f5e
Compare
danesfeder
added
ready for review
and removed
⚠️ DO NOT MERGE
cammace
approved these changes
Jul 11, 2017
…lestoneEventListener
…ructions given during a nav session
danesfeder
force-pushed
the
dan-custom-instruction
branch
from
60d4f5e
to
28d99c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #103
This PR will allow developers to create their own custom instruction classes subclassing
Instructionand setting it to the givenMilestone.When the
Milestoneis triggered, theStringprovided bysetInstruction(RouteProgress)will be theStringpassed to theMilestoneEventListenercc: @cammace @zugaldia @ericrwolfe