Fix OffRoute engine cleared before service shutdown #1167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -97,6 +97,7 @@ public void onDestroy(boolean isChangingConfigurations) { | |||
| deactivateInstructionPlayer(); | |||
| endNavigation(); | |||
| } | |||
| navigation.setCameraEngine(null); | |||
There was a problem hiding this comment.
This is currently doing nothing 👀
public void setCameraEngine(@NonNull Camera cameraEngine) {
navigationEngineFactory.updateCameraEngine(cameraEngine);
}👇
void updateCameraEngine(Camera cameraEngine) {
if (cameraEngine == null) {
return;
}
this.cameraEngine = cameraEngine;
}Also, note
Passing 'null' argument to parameter annotated as
@NotNull
Guardiola31337
approved these changes
Aug 3, 2018
danesfeder
force-pushed
the
dan-off-route-clear-engine
branch
from
9fdc873
to
3c41a7a
Compare
Guardiola31337
force-pushed
the
dan-off-route-clear-engine
branch
from
3c41a7a
to
c53a363
Compare
Guardiola31337
force-pushed
the
dan-off-route-clear-engine
branch
from
c53a363
to
d363cc6
Compare
This was referenced Aug 6, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually Fixes #1139
We are setting the camera engine to
nullhere because it holds ontoMapboxMapand is then given toMapboxNavigation.For the turn-by-turn UI,
MapboxNavigationsurvives rotation, so we need to set it to null so it doesn't leak.