Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify find current banner and voice instructions algorithms #1117

Merged
merged 1 commit into from
Jul 18, 2018

Conversation

Guardiola31337
Copy link
Contributor

Follow up from #1095

  • Simplifies findCurrentBannerInstructions and findCurrentVoiceInstructions algorithms from RouteUtils

cc @dsilvera

@Guardiola31337
Copy link
Contributor Author

findCurrentBannerInstructions_clearsAllInvalidInstructions from RouteUtilsTest is failing in CI when bringing in the new changes 👀

com.mapbox.services.android.navigation.v5.utils.RouteUtilsTest > findCurrentBannerInstructions_clearsAllInvalidInstructions FAILED
    junit.framework.AssertionFailedError at RouteUtilsTest.java:229

Could you take a look at it and try to fix it @dsilvera?
You can run the whole suite executing $> ./gradlew test

Let us know if you have any questions. Thanks!

@danesfeder
Copy link
Contributor

@Guardiola31337 noting that this test is probably not needed with the new algorithm setup

@Guardiola31337
Copy link
Contributor Author

noting that this test is probably not needed with the new algorithm setup

Yeah, that's what I was 👀 - with the new algo we're not removing the elements anymore.

Going ahead and removing that test.

Thanks for confirming @danesfeder

@Guardiola31337
Copy link
Contributor Author

Could you take a look at it and try to fix it @dsilvera?

Nevermind @dsilvera as I said #1117 (comment) I went ahead and removed the pointless test and now tests should be ✅

Thanks again for the contribution!

@danesfeder danesfeder self-requested a review July 18, 2018 17:12
@danesfeder danesfeder added this to the 0.16.0 milestone Jul 18, 2018
Copy link
Contributor

@danesfeder danesfeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once CI ✅ thanks a lot for the contribution @dsilvera!

@Guardiola31337 Guardiola31337 merged commit a0d38cf into master Jul 18, 2018
@Guardiola31337 Guardiola31337 deleted the dsilvera-instructions-refactor branch July 18, 2018 17:56
@danesfeder danesfeder mentioned this pull request Jul 20, 2018
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants