Check for changing config only if activity is finishing

mapbox · Jan 16, 2018 · 4f16ba9 · 4f16ba9
1 parent 745ce4a
commit 4f16ba9
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 16 deletions.
diff --git a/...ion-ui/src/main/java/com/mapbox/services/android/navigation/ui/v5/NavigationActivity.java b/...ion-ui/src/main/java/com/mapbox/services/android/navigation/ui/v5/NavigationActivity.java
@@ -22,6 +22,7 @@
 public class NavigationActivity extends AppCompatActivity implements OnNavigationReadyCallback, NavigationListener {
 
   private NavigationView navigationView;
+  private boolean isConfigurationChange;
 
   @Override
   protected void onCreate(@Nullable Bundle savedInstanceState) {
@@ -31,6 +32,7 @@ protected void onCreate(@Nullable Bundle savedInstanceState) {
     navigationView = findViewById(R.id.navigationView);
     navigationView.onCreate(savedInstanceState);
     navigationView.getNavigationAsync(this);
+    isConfigurationChange = savedInstanceState != null;
   }
 
   @Override
@@ -69,8 +71,10 @@ protected void onDestroy() {
   public void onNavigationReady() {
     NavigationViewOptions.Builder options = NavigationViewOptions.builder();
     options.navigationListener(this);
-    extractRoute(options);
-    extractCoordinates(options);
+    if (!isConfigurationChange) {
+      extractRoute(options);
+      extractCoordinates(options);
+    }
     extractConfiguration(options);
     navigationView.startNavigation(options.build());
   }

diff --git a/.../src/main/java/com/mapbox/services/android/navigation/v5/navigation/MapboxNavigation.java b/.../src/main/java/com/mapbox/services/android/navigation/v5/navigation/MapboxNavigation.java
@@ -390,7 +390,6 @@ public void endNavigation() {
       context.unbindService(this);
       isBound = false;
       navigationEventDispatcher.onNavigationEvent(false);
-      navigationTelemetry.endSession();
     }
   }
 

diff --git a/...java/com/mapbox/services/android/navigation/v5/navigation/NavigationLifecycleMonitor.java b/...java/com/mapbox/services/android/navigation/v5/navigation/NavigationLifecycleMonitor.java
@@ -54,10 +54,8 @@ public void onActivityPaused(Activity activity) {
 
   @Override
   public void onActivityDestroyed(Activity activity) {
-    if (activity.isChangingConfigurations()) {
-      NavigationTelemetry.getInstance().onConfigurationChange();
-    }
     if (activity.isFinishing()) {
+      NavigationTelemetry.getInstance().endSession(activity.isChangingConfigurations());
       activity.getApplication().unregisterActivityLifecycleCallbacks(this);
     }
   }

diff --git a/...c/main/java/com/mapbox/services/android/navigation/v5/navigation/NavigationTelemetry.java b/...c/main/java/com/mapbox/services/android/navigation/v5/navigation/NavigationTelemetry.java
@@ -146,9 +146,6 @@ void initialize(@NonNull Context context, @NonNull String accessToken,
 
       validateAccessToken(accessToken);
 
-      // Setup the listeners
-      initEventDispatcherListeners(navigation);
-
       MapboxNavigationOptions options = navigation.options();
       // Set sdkIdentifier based on if from UI or not
       String sdkIdentifier = updateSdkIdentifier(options);
@@ -168,6 +165,8 @@ void initialize(@NonNull Context context, @NonNull String accessToken,
 
       isInitialized = true;
     }
+    // Setup the listeners
+    initEventDispatcherListeners(navigation);
   }
 
   /**
@@ -200,16 +199,16 @@ void startSession(DirectionsRoute directionsRoute) {
         .mockLocation(metricLocation.getLocation().getProvider().equals(MOCK_PROVIDER))
         .rerouteCount(0)
         .build();
-    } else {
-      isConfigurationChange = false;
     }
+    isConfigurationChange = false;
   }
 
   /**
    * Flushes any remaining events from the reroute / feedback queue and fires
    * a cancel event indicating a terminated session.
    */
-  void endSession() {
+  void endSession(boolean isConfigurationChange) {
+    this.isConfigurationChange = isConfigurationChange;
     if (!isConfigurationChange) {
       if (navigationSessionState.startTimestamp() != null) {
         flushEventQueues();
@@ -274,10 +273,6 @@ void updateLocationEngine(LocationEngine locationEngine) {
     }
   }
 
-  void onConfigurationChange() {
-    isConfigurationChange = true;
-  }
-
   /**
    * Creates a new {@link FeedbackEvent} and adds it to the queue
    * of events to be sent.