Fix query tests for v2 features #91
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @jfirebaugh @ansis @jakepruitt @mapsam
There are a number of tests that began failing after the v2 upgrade due to reliance on undefined behaviour. These tests fall into two categories:
Failing Hidden Symbol Tests
These tests were relying on label placement. Changes in geometries, such as merging lines with identical properties, caused the label placement to shift enough to cause these tests to fail.
What the test was supposed to be
What the test was after v2 upgrade
Other Failing Tests
Many other tests were failing because they were querying the edge of rendered features, getting just enough of an antialiased pixel to return the expected results.
Bonus:
expected.jsonIndentationThe
query-tests/*/*/expected.jsonfiles now use 4 spaces for indentation, consistent with other JSON files in this repository.