Fix bug and add test for empty text handling in styled bidirectional processing #36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix return format for
processStyledBidirectionalTextwith empty inputThe
processStyledBidirectionalTextfunction was returning an incorrect format when given empty text. It returned[{text, styleIndices}](an object wrapped in an array) instead of[[text, styleIndices]](a tuple/array wrapped in an array).This caused issues in maplibre-gl-js when both
nameandreffields were empty (see maplibre/maplibre-gl-js#6444).Changes:
src/index.jsto return[[text, styleIndices]]The fix ensures consistency with the function's documented return type:
Array<[string, Array<number>]>