Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Limit Viewport #8622

Merged
merged 1 commit into from
Apr 13, 2017
Merged

Limit Viewport #8622

merged 1 commit into from
Apr 13, 2017

Conversation

tobrun
Copy link
Member

@tobrun tobrun commented Apr 3, 2017

Android binding integration of #8583.

ezgif com-video-to-gif 13

closes #3602

@tobrun tobrun added the Android Mapbox Maps SDK for Android label Apr 3, 2017
@tobrun tobrun added this to the android-v5.1.0 milestone Apr 3, 2017
@tobrun tobrun requested a review from ivovandongen April 3, 2017 12:38
@tobrun tobrun self-assigned this Apr 3, 2017
Copy link
Contributor

@ivovandongen ivovandongen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes, looks good otherwise!

@@ -348,6 +349,14 @@ void NativeMapView::setStyleJson(jni::JNIEnv& env, jni::String json) {
map->setStyleJSON(jni::Make<std::string>(env, json));
}

void NativeMapView::setLatLngBounds(jni::JNIEnv& env, jni::Object<mbgl::android::LatLngBounds> jBounds) {
if(jBounds==NULL){
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: some spaces

void NativeMapView::setLatLngBounds(jni::JNIEnv& env, jni::Object<mbgl::android::LatLngBounds> jBounds) {
if(jBounds==NULL){
map->setLatLngBounds(mbgl::LatLngBounds::world());
}else{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more spaces

@@ -110,6 +111,8 @@ class NativeMapView : public View, public Backend {

void setStyleJson(jni::JNIEnv&, jni::String);

void setLatLngBounds(jni::JNIEnv& env, jni::Object<mbgl::android::LatLngBounds>);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, remove env

@tobrun tobrun force-pushed the android-map-latlngbounds branch 3 times, most recently from e0442f9 to 8061a59 Compare April 13, 2017 11:43
@tobrun
Copy link
Member Author

tobrun commented Apr 13, 2017

#8583 landed, ready for final review @ivovandongen?

Copy link
Contributor

@ivovandongen ivovandongen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tobrun tobrun merged commit 21f54cc into master Apr 13, 2017
@tobrun tobrun deleted the android-map-latlngbounds branch April 13, 2017 14:06
@tobrun tobrun mentioned this pull request May 2, 2017
12 tasks
@tobrun tobrun mentioned this pull request Jun 9, 2017
12 tasks
@tobrun tobrun mentioned this pull request Jun 21, 2017
11 tasks
@tobrun tobrun mentioned this pull request Jun 30, 2017
16 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Limit Viewport
2 participants