-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Conversation
37344dc
to
82ce572
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small changes, looks good otherwise!
@@ -348,6 +349,14 @@ void NativeMapView::setStyleJson(jni::JNIEnv& env, jni::String json) { | |||
map->setStyleJSON(jni::Make<std::string>(env, json)); | |||
} | |||
|
|||
void NativeMapView::setLatLngBounds(jni::JNIEnv& env, jni::Object<mbgl::android::LatLngBounds> jBounds) { | |||
if(jBounds==NULL){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: some spaces
void NativeMapView::setLatLngBounds(jni::JNIEnv& env, jni::Object<mbgl::android::LatLngBounds> jBounds) { | ||
if(jBounds==NULL){ | ||
map->setLatLngBounds(mbgl::LatLngBounds::world()); | ||
}else{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more spaces
@@ -110,6 +111,8 @@ class NativeMapView : public View, public Backend { | |||
|
|||
void setStyleJson(jni::JNIEnv&, jni::String); | |||
|
|||
void setLatLngBounds(jni::JNIEnv& env, jni::Object<mbgl::android::LatLngBounds>); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit, remove env
e0442f9
to
8061a59
Compare
#8583 landed, ready for final review @ivovandongen? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
8061a59
to
4941aa9
Compare
Android binding integration of #8583.
closes #3602