Fixed incorrect notification

[maciekish]

This is incorrect, no?

UIGestureRecognizerStateChanged should yield MapChangeRegionIsChanging and not until UIGestureRecognizerStateEnded should you get MapChangeRegionDidChangeAnimated.

[1ec5]

Thanks @maciekish! MGLMapView has a few more gesture recognizers (-handleQuickZoomGesture:, -handleRotateGesture:, -handleTwoFingerDragGesture:) that would benefit from the same notification flow.

[maciekish]

@1ec5 I added it to the quick zoom, but should rotate and pitch really send this notification? From what i understand they don't really change the actual region? I held off with this until further notice because handleTwoFingerDragGesture state == UIGestureRecognizerStateEnded has a commented out //[self notifyMapChange:(mbgl::MapChangeRegionDidChange)]; which leads me to believe that someone thought the same..

[friedbunny]

I held off with this until further notice because handleTwoFingerDragGesture state == UIGestureRecognizerStateEnded has a commented out //[self notifyMapChange:(mbgl::MapChangeRegionDidChange)]; which leads me to believe that someone thought the same..

That would be me. 😏

Changing the pitch of the map does change the visible region and it should give a change notification, but I never got around to testing the practical effects of actually sending this notification.

[maciekish]

It changes the visible region - but does it change mapView.visibleCoordinateBounds?

If i recall correctly it does not, and i would only want notifications when the visibleCoordinateBounds change. Otherwise it's not of much use because it will say "hey, something changed" but not what the new values are.

[t-yoshii]

I have a same problem. Will this be merged shortly?

[1ec5]

I added it to the quick zoom, but should rotate and pitch really send this notification? From what i understand they don't really change the actual region?

Rotating by 45° does expand the visible coordinate bounds a bit. Tilting the map should alter the visible coordinate bounds but currently does not, due to #2259.

[1ec5]

Thanks for the PR and your patience – tracking as #2700 now.