This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
#2329 Constrain map to user specified bounds #2341
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the user to constrain movement of the map to a specific area.
Example
Set the bounds to lock the map to Sweden:
Implemented in
transform_state.cpp
by looking at how the existingTransformState::constrain(double& scale_, double& y_)
function works to prevent panning the map outside 90 degrees latitude.The new function
TransformState::userConstrain(double& scale_, double& x_, double& y_)
will constrain scale, x and y. By implementing it at this level both panning, flicking, pinching, double tapping and tapping the map with two fingers will be correctly constrained to the given coordinates. It does however not take angle or pitch into account.Requested by me in #2329, but since i don't like waiting i went ahead and did it myself. This is my first c++ code ever so please be gentle :) Any feedback is appreciated.