This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core][tile mode] Fix variable placement + icon-text-fit #16382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pozdnyakov
added
the
needs changelog
astojilj
approved these changes
Apr 8, 2020
pozdnyakov
changed the title
pozdnyakov
force-pushed
the
mikhail_tile_mode_variable_labels_with_icon_text_fit
branch
from
faba08d
to
f776cfa
Compare
pozdnyakov
added
Core
pozdnyakov
deleted the
mikhail_tile_mode_variable_labels_with_icon_text_fit
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
symbolIntersectsTileEdges()util inmbgl::TilePlacementnow considers icon shift for the variable symbols with enabledicon-text-fitsetting, thus providing more accurate results.Render test: mapbox/mapbox-gl-js#9513
Fixes https://github.com/mapbox/mapbox-gl-native-team/issues/213