-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[core] Bring more stability to the symbol placement #16287
Conversation
e5330b8
to
f81592c
Compare
Overall this looks good! This looks like it prioritizes previously placed symbols within each sortkeyrange/layer but layer priority will still be respected? This seems like a great compromise to me.
It looks like they are allowed to be only their last used anchor. Did this make a large change for stability? Overall this looks good to me! I think it's worth considering making this the default behavior instead of just for tilted views to keep things simpler |
Yeah, the symbol once placed does not change its anchor - otherwise symbols are "jumping" while camera is moving |
the first change "place already visible symbols first and hidden symbols last" could be a default behavior indeed, however the other changes IMO are more navigation mode specific. |
f81592c
to
5d20959
Compare
@pozdnyakov this is great, thank you! Before you merge, may I suggest a small modification to the changelog:
|
718cea6
to
8b694de
Compare
8b694de
to
aab5230
Compare
If the view is not tilted, we want the new symbols to show up faster, so we squeeze the placement period. On contrary, with the tilted view it's more important to make placement rarely for performance reasons and as the new symbols are normally "far away" and the user is not that interested to see them ASAP.
This is done in order to improve labels stability and for the performace reasons.
aab5230
to
58d0ffc
Compare
58d0ffc
to
67ba54d
Compare
This pull request improves the labels stability and performance for the tilted view. The following changes are done:
Fixes https://github.com/mapbox/mapbox-gl-native-team/issues/132