Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Bump mapbox-gl-js version and backport gl-js fix 'Hide glyphs behind the camera'(mapbox/mapbox-gl-js#9229) #16189

Merged
merged 2 commits into from
Feb 11, 2020
Merged

Bump mapbox-gl-js version and backport gl-js fix 'Hide glyphs behind the camera'(mapbox/mapbox-gl-js#9229) #16189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dda49ea
Bump GL-JS
zmiao Feb 10, 2020
7540bf9
Add new metric baselines
zmiao Feb 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion circle.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ commands:
command: |
platform/darwin/scripts/generate-style-code.js
platform/darwin/scripts/update-examples.js
git add -A && git diff --staged --exit-code
git add -A && git diff --staged --exit-code | tee nitpick.patch
config:
parameters:
config_params:
Expand Down
2 changes: 1 addition & 1 deletion mapbox-gl-js
Open in desktop
Submodule mapbox-gl-js updated 175 files
35 changes: 35 additions & 0 deletions ...droid-render-test-runner/render-tests/line-gradient/gradient-tile-boundaries/metrics.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
{
"network": [
[
"probeNetwork - default - end",
0,
0
],
[
"probeNetwork - default - start",
0,
0
]
],
"gfx": [
[
"probeGFX - default - end",
4,
6,
9,
1,
[
66560,
66560
],
[
94,
94
],
[
192,
192
]
]
]
}
35 changes: 35 additions & 0 deletions metrics/android-render-test-runner/render-tests/regressions/mapbox-gl-js#5171/metrics.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
{
"network": [
[
"probeNetwork - default - end",
0,
0
],
[
"probeNetwork - default - start",
0,
0
]
],
"gfx": [
[
"probeGFX - default - end",
2,
3,
7,
1,
[
32768,
32768
],
[
34,
34
],
[
96,
96
]
]
]
}
35 changes: 35 additions & 0 deletions ...-runner/render-tests/symbol-sort-key/placement-tile-boundary-left-then-right/metrics.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
{
"network": [
[
"probeNetwork - default - end",
2,
211659
],
[
"probeNetwork - default - start",
0,
0
]
],
"gfx": [
[
"probeGFX - default - end",
3,
7,
13,
1,
[
53920,
53920
],
[
58,
58
],
[
544,
544
]
]
]
}
35 changes: 35 additions & 0 deletions metrics/android-render-test-runner/render-tests/text-size/zero/metrics.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
{
"network": [
[
"probeNetwork - default - end",
1,
84942
],
[
"probeNetwork - default - start",
0,
0
]
],
"gfx": [
[
"probeGFX - default - end",
1,
21,
9,
1,
[
215688,
215688
],
[
58,
58
],
[
544,
544
]
]
]
}
31 changes: 30 additions & 1 deletion metrics/ignores/platform-all.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
"expression-tests/legacy/interval/composite-default": "https://github.com/mapbox/mapbox-gl-native/issues/12747",
"expression-tests/legacy/interval/tokens-zoom": "https://github.com/mapbox/mapbox-gl-native/issues/12747",
"expression-tests/resolved-locale/basic": "Even the 'en' locale may not be present on some test systems.",
"expression-tests/within/basic": "TODO: Fix by implementing `within` expression",
"expression-tests/within/invalid-geojson": "TODO: Fix by implementing `within` expression",
"probes/file-size/fail-file-doesnt-match": "Should fail, doesn't match the expectation.",
"probes/file-size/fail-file-not-found": "Should fail, file not found.",
"probes/file-size/fail-size-is-over": "Should fail, size is bigger than expected.",
Expand Down Expand Up @@ -55,6 +57,7 @@
"query-tests/regressions/mapbox-gl-js#6555": "skip - no querySourceFeatures in mbgl-node; needs issue",
"query-tests/regressions/mapbox-gl-js#7883": "https://github.com/mapbox/mapbox-gl-native/issues/14585",
"query-tests/world-wrapping/box": "skip - needs issue",
"query-tests/regressions/mapbox-gl-js#8999": "https://github.com/mapbox/mapbox-gl-js/pull/9138",
"render-tests/background-color/colorSpace-hcl": "needs issue",
"render-tests/background-color/transition": "https://github.com/mapbox/mapbox-gl-native/issues/10619",
"render-tests/canvas/default": "skip - js specific",
Expand Down Expand Up @@ -111,5 +114,31 @@
"render-tests/text-variable-anchor/remember-last-placement": "skip - fails on gl-native, as symbol index is not functional at static map mode - needs issue",
"render-tests/tilejson-bounds/overwrite-bounds": "started failing after https://github.com/mapbox/mapbox-gl-native/pull/16091",
"render-tests/video/default": "skip - https://github.com/mapbox/mapbox-gl-native/issues/601",
"render-tests/zoomed-fill/negative-zoom": "https://github.com/mapbox/mapbox-gl-native/issues/16019"
"render-tests/zoomed-fill/negative-zoom": "https://github.com/mapbox/mapbox-gl-native/issues/16019",
"render-tests/zoomed-fill/negative-zoom": "https://github.com/mapbox/mapbox-gl-native/issues/16019",
"render-tests/fill-extrusion-translate/default": "https://github.com/mapbox/mapbox-gl-js/pull/9202",
"render-tests/fill-extrusion-opacity/literal": "https://github.com/mapbox/mapbox-gl-js/pull/9202",
"render-tests/fill-extrusion-opacity/default": "https://github.com/mapbox/mapbox-gl-js/pull/9202",
"render-tests/fill-extrusion-opacity/function": "https://github.com/mapbox/mapbox-gl-js/pull/9202",
"render-tests/fill-extrusion-vertical-gradient/default" : "https://github.com/mapbox/mapbox-gl-js/pull/9202",
"render-tests/fill-extrusion-vertical-gradient/false": "https://github.com/mapbox/mapbox-gl-js/pull/9202",
"render-tests/fill-extrusion-base/zoom-and-property-function": "https://github.com/mapbox/mapbox-gl-js/pull/9202",
"render-tests/fill-extrusion-base/property-function": "https://github.com/mapbox/mapbox-gl-js/pull/9202",
"render-tests/extent/1024-symbol": "https://github.com/mapbox/mapbox-gl-js/pull/9202",
"render-tests/projection/perspective": "https://github.com/mapbox/mapbox-gl-js/pull/9202",
"render-tests/feature-state/promote-id-fill":"https://github.com/mapbox/mapbox-gl-js/pull/9202",
"render-tests/feature-state/promote-id-symbol": "https://github.com/mapbox/mapbox-gl-js/pull/9202",
"render-tests/feature-state/promote-id-line": "https://github.com/mapbox/mapbox-gl-js/pull/9202",
"render-tests/feature-state/promote-id-circle": "https://github.com/mapbox/mapbox-gl-js/pull/9202",
"render-tests/feature-state/promote-id-fill-extrusion": "https://github.com/mapbox/mapbox-gl-js/pull/9202",
"render-tests/text-variable-anchor/left-top-right-buttom-offset-tile-map-mode":"https://github.com/mapbox/mapbox-gl-js/pull/9202",
"render-tests/line-pattern/with-dasharray":"https://github.com/mapbox/mapbox-gl-js/pull/9189",
"render-tests/symbol-sort-key/placement-tile-boundary-right-then-left": "https://github.com/mapbox/mapbox-gl-js/pull/9054",
"render-tests/line-dasharray/zero-length-gap":"https://github.com/mapbox/mapbox-gl-js/pull/9246",
"render-tests/within/layout-text": "TODO: Fix by enabling `within` expreesion with layout property",
"render-tests/within/filter-with-inlined-geojson": "TODO: Fix by enabling `within` expreesion with filter expression",
"render-tests/within/paint-circle": "TODO: Fix by enabling `within` expreesion with paint property",
"render-tests/within/paint-icon": "TODO: Fix by enabling `within` expreesion with paint property",
"render-tests/within/paint-text": "TODO: Fix by enabling `within` expreesion with paint property"

}
35 changes: 35 additions & 0 deletions ...s/ios-render-test-runner/render-tests/line-gradient/gradient-tile-boundaries/metrics.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
{
"network": [
[
"probeNetwork - default - end",
0,
0
],
[
"probeNetwork - default - start",
0,
0
]
],
"gfx": [
[
"probeGFX - default - end",
4,
6,
9,
1,
[
66560,
66560
],
[
94,
94
],
[
192,
192
]
]
]
}
35 changes: 35 additions & 0 deletions metrics/ios-render-test-runner/render-tests/regressions/mapbox-gl-js#5171/metrics.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
{
"network": [
[
"probeNetwork - default - end",
0,
0
],
[
"probeNetwork - default - start",
0,
0
]
],
"gfx": [
[
"probeGFX - default - end",
2,
3,
7,
1,
[
32768,
32768
],
[
34,
34
],
[
96,
96
]
]
]
}
35 changes: 35 additions & 0 deletions ...-runner/render-tests/symbol-sort-key/placement-tile-boundary-left-then-right/metrics.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
{
"network": [
[
"probeNetwork - default - end",
2,
211659
],
[
"probeNetwork - default - start",
0,
0
]
],
"gfx": [
[
"probeGFX - default - end",
3,
7,
13,
1,
[
53920,
53920
],
[
58,
58
],
[
544,
544
]
]
]
}
35 changes: 35 additions & 0 deletions metrics/ios-render-test-runner/render-tests/text-size/zero/metrics.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
{
"network": [
[
"probeNetwork - default - end",
1,
84942
],
[
"probeNetwork - default - start",
0,
0
]
],
"gfx": [
[
"probeGFX - default - end",
1,
21,
9,
1,
[
215688,
215688
],
[
58,
58
],
[
544,
544
]
]
]
}
35 changes: 35 additions & 0 deletions ...ics/linux-clang8-release/render-tests/line-gradient/gradient-tile-boundaries/metrics.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
{
"network": [
[
"probeNetwork - default - end",
0,
0
],
[
"probeNetwork - default - start",
0,
0
]
],
"gfx": [
[
"probeGFX - default - end",
4,
6,
9,
1,
[
66560,
66560
],
[
94,
94
],
[
192,
192
]
]
]
}
Loading